Bsky #9
Merged
Bsky #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Run Then manually fix anything it can't |
mattmatters
requested changes
Mar 20, 2025
Collaborator
mattmatters
left a comment
mattmatters
left a comment
There was a problem hiding this comment.
Nice work ❤️! Just take care of the lint issues and follow up on some questions and we can get this in!
Since you got behave working again it would be worth adding it to the ci pipeline.
Comment on lines
-7
to
+8
| import twitter | ||
| from atproto import Client | ||
| from atproto import IdResolver |
Collaborator
There was a problem hiding this comment.
It doesn't look like this was added to requirements/prod.txt
bluto/markov.py
Outdated
| return tweets | ||
| def get_avatar_url(username): | ||
| """Get the URL of <username>'s avatar""" | ||
| client = Client() |
Collaborator
There was a problem hiding this comment.
Any reason we don't initialize this globally?
Collaborator
Author
There was a problem hiding this comment.
We certainly can
Collaborator
Author
There's a lot of conflicts with the features/ directory that Behave uses due to how Behave files are set up -edit Fixed where the directory should be excluded in pyproject.toml since I moved it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Twitter API calls to Bluesky AT Protocol calls
Adds missing 401.html and 500.html
Fixes results page not correctly loading
Updates Behave test location
Shiny new favicon image