WIP: Move polarplot and waterfallplot to use material and shaders#874
Open
patrickelectric wants to merge 20 commits intobluerobotics:masterfrom
Open
WIP: Move polarplot and waterfallplot to use material and shaders#874patrickelectric wants to merge 20 commits intobluerobotics:masterfrom
patrickelectric wants to merge 20 commits intobluerobotics:masterfrom
Conversation
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
tcanabrava
reviewed
Feb 7, 2020
Contributor
tcanabrava
left a comment
tcanabrava
left a comment
There was a problem hiding this comment.
This code still seems to be a rather raw WIP, so it's better to finalize it before a proper review.
Member
Author
|
Thanks for you review Tom, but this is a WIP. Hopefully everything will be
cleaned when done
…On Fri, Feb 7, 2020, 8:18 AM Tomaz Canabrava ***@***.***> wrote:
***@***.**** commented on this pull request.
This code still seems to be a rather raw WIP, so it's better to finalize
it before a proper review.
------------------------------
In pingviewer.pro
<#874 (comment)>
:
> @@ -24,7 +24,7 @@ RESOURCES += \
# Warning as error
*-g++ | *-clang {
- QMAKE_CXXFLAGS += -Werror
+ #QMAKE_CXXFLAGS += -Werror
maybe pass -Wall -Wextra -pedantic but without -Werror ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#874?email_source=notifications&email_token=AAJIYCNNOG234NSN245DK5DRBU7P5A5CNFSM4KD22KH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUVD4NQ#pullrequestreview-355089974>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJIYCMS5BQIMJIBVNK3VEDRBU7P5ANCNFSM4KD22KHQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.