Fix log decode Python example#1095
Merged
patrickelectric merged 3 commits intobluerobotics:masterfrom Aug 7, 2025
Merged
Conversation
f166fed to
1ec2923
Compare
patrickelectric
requested changes
Aug 6, 2025
1ec2923 to
ec5195f
Compare
patrickelectric
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Attempting to resolve reported decoding issues.
Progress
SyntaxWarningfrom the regex definition of the timestamp formatStatus
The remaining parsing issue is fixed by upgrading to v0.2.0 of the library (e.g. via
pip install --upgrade bluerobotics-ping).Parsing issue details
Still finding and fixing errors.Parsing issues are caused by ping-python not treating auto_device_data messages as variable length. That is already fixed in the codebase, so just needs to be included in a new release of that repo (@patrickelectric can we make one? 🙂).It is possible to confirm with
pip install git+https://github.com/bluerobotics/ping-python@deploymentif relevant.This PR still fixes a problem and cleans some things up, so can be merged under that merit.Parsing this example log file (which includes theauto_device_datafunctionality) is resulting in: