Skip to content

Conversation

@kylesferrazza
Copy link

@kylesferrazza kylesferrazza commented Nov 11, 2019

Work in progress.
Closes CodeGrade#161.

jQuery Migrate added, working on fixing warnings.
Fixes for each warning can be found here.

TODO:

  • fix all warnings
  • remove migrate
    • node module
    • import in application.js
  • move jquery-ui-rails fork to CodeGrade

If we don't fix upstream warnings we may want to switch to the minified production version of migrate and keep it for compatibility.

@kylesferrazza
Copy link
Author

kylesferrazza commented Nov 11, 2019

'ready' event is deprecated

from cocoon, seems okay since turbolinks:load is called as well:
nathanvda/cocoon#514

@kylesferrazza
Copy link
Author

kylesferrazza commented Nov 11, 2019

jQuery.expr[':'] is deprecated; use jQuery.expr.pseudos

from jquery-ui/mouse

jquery-ui-rails has jquery-ui pinned at jquery/jquery-ui@c6f1735 (v1.12.1 - from sep 14, 2016) and this warning was fixed in jquery/jquery-ui@0b7246b (from dec 2, 2016)

jquery-ui hasn't had a new release (but 55 commits to master) since 1.12.1

The milestone for 1.12.2 reads 3 years late

@kylesferrazza
Copy link
Author

kylesferrazza commented Nov 11, 2019

jQuery.fn.unbind() is deprecated / jQuery.fn.bind() is deprecated

Mottie/tablesorter#1292

@kylesferrazza
Copy link
Author

Treeviews broken - seems like initial state is not set up at the right time.
Probably due to changes to $.Deferred: https://jquery.com/upgrade-guide/3.0/#deferred

@kylesferrazza
Copy link
Author

  • rebase and move to codegrade/bottlenose after webpacker is set up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade JQuery to v3.4.*

1 participant