update #7
Merged
update #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated package.json engines field to explicitly support Node.js 22. Verified successful build from source using npm install --build-from-source with Node.js 22.21.1. All native modules compile correctly with C++17.
Updated all CI jobs (Linux, macOS, Windows) to test on both Node.js 20.x and 22.x. Tests pass successfully on Node.js 22.21.1 when building from source.
The macOS workflow doesn't run documentation example test generation (unlike Linux and Windows), so it doesn't need mustache. Removing this step prevents the ZeroMQ dependency installation failure.
Remove --clang=1 and --debug flags from macOS build command as they were being misinterpreted by npm. The --clang=1 flag caused npm to try installing a package named "1" which has zmq as a dependency. These flags aren't necessary: - clang is already the default compiler on macOS - debug builds are not required for CI testing
Node.js 22 on Windows fails to build due to C++ operator overloading ambiguities caught by node-gyp 11.2.0 with MSVC 2022. The stricter C++20 compliance causes errors like: - C2666: '==' overloaded functions have similar conversions - C2677: binary '+' no global operator found for TChA These require C++ code fixes to resolve implicit conversion issues between types (char/TCh, int/TInt, etc). Until these are addressed, Windows CI will only test Node.js 20.x. Node.js 22 support on Linux and macOS is unaffected.
…dwhiKaQo5VhaRJGN16 Claude/node 22 build source 011 c uxdwhi ka qo5 vha rjgn16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.