fix: remove requestedExplicitly check for non-text files #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the requestedExplicitly check that filtered out images and PDFs unless explicitly requested by name or extension. Now all files matching glob patterns are included regardless of file type. Fixes issue where directories with assets appeared empty and "list all files" queries returned misleading results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where the
read-many-filestool incorrectly filtered out images and PDFs unless they were explicitly requested, causing directories with assets to appear empty.Problem
The tool skipped non-text files when using broad glob patterns like
*, resulting in incomplete file listings.Solution
Removed the
requestedExplicitlycheck so that all files matching glob patterns are included, regardless of file type.Changes
packages/core/src/tools/read-many-files.tsrequestedExplicitlycheckTesting
Fixes #26