Skip to content
This repository was archived by the owner on Jun 22, 2023. It is now read-only.

Comments

Doc tweaks to list view switcher docs#751

Merged
blackbaud-johnly merged 5 commits intolist-view-switcher-docsfrom
list-view-switcher-edits
Feb 3, 2020
Merged

Doc tweaks to list view switcher docs#751
blackbaud-johnly merged 5 commits intolist-view-switcher-docsfrom
list-view-switcher-edits

Conversation

@blackbaud-johnly
Copy link
Contributor

Edits to the content at #749 and a first stab at the development side of #726 (minus the demo).

Copy link
Contributor Author

@blackbaud-johnly blackbaud-johnly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a handful of questions in addition to the docs edits...

@Blackbaud-AdamFunderburk
Copy link
Contributor

At least in the version of the PR I'm seeing, the images in the States table are using borders, which they should not. Images in the states table do not need borders, and do not need to conform to 290/600 width requirements.

@blackbaud-johnly
Copy link
Contributor Author

I see the borders on the States images too, but I assume we can address that in #749. I didn't add borders in my branch.

@blackbaud-johnly blackbaud-johnly changed the title Doc tweaks to list view switcher docs [HOLD] Doc tweaks to list view switcher docs Jan 9, 2020
@blackbaud-johnly
Copy link
Contributor Author

@Blackbaud-AdamFunderburk @Blackbaud-ToddRoberts, and @Blackbaud-TrevorBurch, I went back through the docs and made a handful of updates to get these docs ready to go without the demo and code samples. We still have three unresolved comments, but I think two are addressed and just need confirmation. And I think we need to file a separate issue for the other one, but I'd like confirmation there too. If anyone can take a look at the comments and give the docs a once-over, I think we can get this merged into the parent branch this week and then hopefully get that PR out to update the docs site. Please just let me know if you see any problems or need anything else from me on this. Thanks!

@blackbaud-johnly blackbaud-johnly changed the title [HOLD] Doc tweaks to list view switcher docs Doc tweaks to list view switcher docs Feb 3, 2020
@blackbaud-johnly blackbaud-johnly merged commit f35b6d6 into list-view-switcher-docs Feb 3, 2020
@blackbaud-johnly blackbaud-johnly deleted the list-view-switcher-edits branch February 3, 2020 15:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants