Updated mssclient.py to Python3.#3
Open
0xdf-0xdf wants to merge 1 commit intoblackarrowsec:masterfrom
Open
Conversation
Updated to Python3:
- byte strings where needed
- import _thread instread of thread
- replaced `encode.('hex')` with `hex()`
Also moved listening message to where listening
actually happens. On slow machines, can give the
impression that it is listening before it is.
Changes to be committed:
modified: mssqlclient.py
Member
|
Hey! We've thought about a Python3 release but keeping Python2 compatibility as well, like other Impacket examples do. We are open for a new pull request if you want to. Thank you! |
|
The upload and download features you've came up with are awesome, and 0xdf has already ported it to python3. I feel like putting that code to the main impacket |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With python2 largely going away, and things like pip2 and python setup tools are difficult to find and install. Even just getting impacket as Python2 onto a new VM is challenging.
Updated to Python3 required small changes.
encode.('hex')withhex()Also moved listening message to where listening
actually happens. On slow machines, can give the
impression that it is listening before it is.
Changes to be committed:
modified: mssqlclient.py