Typing fixes #114
Merged
Typing fixes #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add @OverRide to Requirement.eq, repr and Package.repr - provide typing.override shim with positional-only signature
Add basedpyright and configure it in pyproject.toml. Allow explicit Any and annotate regex helpers with typed Pattern/Match.
- mark setter macro helper as abstract via ABC mixin - define Spec/Package attribute fields with defaults - teach tests to assert non-None before macro expansion
Ensure GitHub Actions runs basedpyright alongside mypy (for now).
Conditionally import the override decorator so Python 3.11's typing module no longer breaks the basedpyright step.
- tighten spec parser typing with override shim and safer macros - annotate helper scripts and tests to make basedpyright happy
Ensure type checkers always import typing_extensions.override so basedpyright sees the decorator and stops reporting implicit override warnings on Python 3.11. Limit the runtime no-op fallback to define its own TypeVar only when typing_extensions is absent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Link: https://docs.basedpyright.com/