Prevent recursive macro expansion loops #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand `%define`/`%global` values as they are read so self-appending
macros settle into concrete strings, seed the builtin `%{nil}`, and
allow empty macro replacements.
Add xscreensaver.spec for testing real-world recursive expansion.
bkircher
force-pushed
the
endless-loop
branch
from
7125f5c to
c1e67aa
Compare
- keep stored macro definitions raw unless they self-reference - add regression test covering deferred conditional expansion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand
%define/%globalvalues as they are read so self-appending macros settle into concrete strings, seed the builtin%{nil}, and allow empty macro replacements.Add xscreensaver.spec for testing real-world recursive expansion.