Use OWNER_PUBKEY to build the WoT network#53
Open
dtonon wants to merge 1 commit intobitvora:masterfrom
Open
Conversation
Contributor
|
I agree that the name is better, but I think most people won't be creating a pubkey for their relays. but now so many people are running it this way it will break their relays if they update :\ |
Contributor
|
I think what i'll do is merge this in for v0.2.0 so relay operators know to at least expect some breaking changes |
Author
|
Yes, it is an hassle, but better now than later. |
fac0fdc to
69aca47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently RELAY_PUBKEY is used to build the WoT network, but this is misleading, in fact in the example .env it is stated "not your npub!", but it actually contains the owner (UTXO) pubkey.
Since RELAY_PUBKEY is used for NIP-11 info, make sense to add a OWNER_PUBKEY env and use it to build the WoT network.
The alternative would be to ask the user to follow himself with the relay account, and add a one level to the following discovering; too complex.