Support a legend key from metric or resource sources #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the legend generation in tsplot/plot.go by allowing the legend key to be sourced from either metric labels or resource labels when the metric label is empty.
- Added fallback logic to use resource labels if the metric label lookup returns an empty string.
- Renamed and clarified the polygon variable (
legendThumbnail) for rendering the legend. - Retained existing legend styling (alignment and padding) while updating how entries are added.
Comments suppressed due to low confidence (1)
tsplot/plot.go:113
- There are no unit tests covering the new fallback logic from resource labels. Please add tests for both cases where the metric label is present and where it falls back to the resource label.
legendEntry := timeSeries.GetMetric().GetLabels()[legendKey]
jharshman
force-pushed
the
support-resource-labels-in-legend
branch
from
eabd4bb to
56e7363
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support sourcing legend value from metric or resource sources. The legend key may belong to either a metric label or resource label.