Open
Conversation
kouloumos
reviewed
Oct 7, 2024
Member
kouloumos
left a comment
kouloumos
left a comment
There was a problem hiding this comment.
While the updated README introduces additional content, it doesn't seem to provide significant extra value or guidance to the repository. The increase in lines doesn't appear to justify the changes made.
Comment on lines
+30
to
+34
| - [Python 3.8+](https://www.python.org/downloads/) | ||
| - [Node.js 14+](https://nodejs.org/) | ||
| - [pip](https://pip.pypa.io/en/stable/) | ||
| - [yarn](https://classic.yarnpkg.com/en/docs/install/) | ||
| - [Elasticsearch](https://www.elastic.co/downloads/elasticsearch) |
Member
There was a problem hiding this comment.
We recently moved away from nodejs implemented scrapers, right? so nodejs and yarn are probably not needed in this list. Also elasticsearch is installed as part of requirements.txt, so I feel that this line will create confusion for people.
Comment on lines
+115
to
+122
| - To run the mailing list scrapers, use the following commands based on the type of documents you want to scrape: | ||
| - **For Linux Foundation Documents** | ||
|
|
||
| Ensure that the `URL` environment variable is set to the appropriate mailing list URL (e.g., `https://lists.linuxfoundation.org/pipermail/lightning-dev/` or `https://lists.linuxfoundation.org/pipermail/bitcoin-dev/`). | ||
| Run the following command: | ||
| ```bash | ||
| node mailing-list/main.js | ||
| ``` |
kouloumos
force-pushed
the
master
branch
16 times, most recently
from
a4bd36f to
2112dad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guide for (this) Scraper Repository