Skip to content

Comments

refactor: remove unused imports in bip-0360 rust implementation#2104

Closed
strmfos wants to merge 1 commit intobitcoin:masterfrom
strmfos:cleanup/remove-unused-imports
Closed

refactor: remove unused imports in bip-0360 rust implementation#2104
strmfos wants to merge 1 commit intobitcoin:masterfrom
strmfos:cleanup/remove-unused-imports

Conversation

@strmfos
Copy link
Contributor

@strmfos strmfos commented Feb 15, 2026

сleaned up unused imports across the codebase:

  • removed std::env from schnorr_example.rs and slh_dsa_key_gen.rs
  • removed unused imports from slh_dsa_verification_example.rs (std::env, log::info, once_cell, bitcoin::hashes)
  • removed Algorithm from data_structures.rs
  • removed MixedLeafInfo from lib.rs
  • removed tagged_hash from test files (p2mr_construction.rs, p2mr_pqc_construction.rs)

all test pass

@murchandamus murchandamus added Pending acceptance This BIP modification requires sign-off by the champion of the BIP being modified Typo-to-be-collected labels Feb 17, 2026
@murchandamus
Copy link
Member

I don’t think this adds substantial value.
@cryptoquick @EthanHeilman, please let me know if you want this to be reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Pending acceptance This BIP modification requires sign-off by the champion of the BIP being modified Typo-to-be-collected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants