Bug fixes

[quantiom]

No description provided.

[birthdates]

What exactly is wrong with this check?

[quantiom]

It will never be true. From what it looks like (and from my testing), it checks if getTransactionRedisKey(txn_id) exists in Redis before it ever adds it.

[birthdates]

It will never be true. From what it looks like (and from my testing), it checks if getTransactionRedisKey(txn_id) exists in Redis before it ever adds it.

Crypto-Store/utils/transaction.ts

Line 103 in d00cf50

redisClient.set(getRedisKey(session), JSON.stringify(data), "EX", 2592000);

It's created here?

[quantiom]

It will never be true. From what it looks like (and from my testing), it checks if getTransactionRedisKey(txn_id) exists in Redis before it ever adds it.

Crypto-Store/utils/transaction.ts

Line 103 in d00cf50

redisClient.set(getRedisKey(session), JSON.stringify(data), "EX", 2592000);

It's created here?

That's storing the result of getRedisKey, which is not the same as the result of getTransactionRedisKey (the one that it checks for)

[birthdates]

It will never be true. From what it looks like (and from my testing), it checks if getTransactionRedisKey(txn_id) exists in Redis before it ever adds it.

Crypto-Store/utils/transaction.ts

Line 103 in d00cf50

redisClient.set(getRedisKey(session), JSON.stringify(data), "EX", 2592000);

It's created here?

That's storing the result of getRedisKey, which is not the same as the result of getTransactionRedisKey (the one that it checks for)

Hmmm weird, from my testing it seemed to work. I'll do some testing on my end before I merge this.

[quantiom]

Have you tested it?