Skip to content
This repository was archived by the owner on Feb 10, 2026. It is now read-only.

Comments

Closes #185: resolve sqlite database connections left open during tes…#204

Merged
reece merged 1 commit intomainfrom
185-sqlite-database-connection-left-open-on-exit-during-testing
Dec 7, 2025
Merged

Closes #185: resolve sqlite database connections left open during tes…#204
reece merged 1 commit intomainfrom
185-sqlite-database-connection-left-open-on-exit-during-testing

Conversation

@reece
Copy link
Member

@reece reece commented Dec 7, 2025

…ting

@reece reece requested a review from a team as a code owner December 7, 2025 05:26
@reece reece linked an issue Dec 7, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Dec 7, 2025

Codecov Report

❌ Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.27%. Comparing base (b459d3d) to head (fd4a2ae).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/biocommons/eutils/_internal/sqlitecache.py 58.33% 4 Missing and 1 partial ⚠️
src/biocommons/eutils/_internal/queryservice.py 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
- Coverage   70.49%   70.27%   -0.23%     
==========================================
  Files          23       23              
  Lines         861      878      +17     
  Branches       50       52       +2     
==========================================
+ Hits          607      617      +10     
- Misses        232      237       +5     
- Partials       22       24       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reece reece merged commit ab89cdb into main Dec 7, 2025
10 of 12 checks passed
@reece reece deleted the 185-sqlite-database-connection-left-open-on-exit-during-testing branch December 7, 2025 05:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sqlite database connection left open on exit during testing

1 participant