Don't use transactions (multi) for bitops#4
Open
msaffitz wants to merge 2 commits intobilus:masterfrom
Open
Conversation
If you use a bitop against a frequently changing bitmap, the multi can be cancelled because the underlying key tracked by watch will change and invalidate the transaction. The biota will then return invalid results (0). This removes the transaction block. Unknown if this is dangerous if the bitmap is in the process of being copied. Causes bitops to not be strongly consistent.
In testing large bitmaps saw a ~50x increase in speed by pipelining operations.
|
@bilus I've also addressed conflicts in this PR in my fork. Can create a new PR addressing these conflicts once #6 is merged, as I included these changes on top of the chunk keys improvements. Will personally start looking into using redis SCAN in lieu of KEYS to reduce latency in my current deployment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you use a bitop against a frequently changing bitmap, the multi can be cancelled because the underlying key tracked by watch will change and invalidate the transaction. The bitop will then return invalid results (0). This removes the transaction block. Unknown if this is dangerous if the bitmap is in the process of being copied. Causes bitops to not be strongly consistent.
This also pipelines bit operations to increase speed. In testing large bitmaps saw a ~50x increase in speed
by pipelining operations.