Fix 500 during contact search; add comments and format files#4
Open
ms wants to merge 1 commit intobigskysoftware:masterfrom
Open
Fix 500 during contact search; add comments and format files#4ms wants to merge 1 commit intobigskysoftware:masterfrom
ms wants to merge 1 commit intobigskysoftware:masterfrom
Conversation
ms
force-pushed
the
fix-500-during-search
branch
from
3d11356 to
1b51a0a
Compare
ms
commented
Sep 10, 2022
| result = [] | ||
| for c in cls.db.values(): | ||
| if text in c.first or text in c.last or text in c.email or text in c.phone: | ||
| if (c.first != None and text in c.first) or (c.last != None and text in c.last) or (c.email != None and text in c.email) or (c.phone != None and text in c.phone): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I’m an early reviewer of the book.
A few minor fixes:
nullvalues. Added a check forNoneThe first item leads me to ask: how does htmx handle HTTP errors? I didn’t see any indication of something being wrong in the UI (I had to open the devtools and then look at the terminal output).
I only tested searching. I’m happy to split this PR up if you prefer to keep commits more atomic in the repo.
Loving the book so far, great work!