Dynamic localization#310
Open
marian-ene-customsoft wants to merge 2 commits intobigcommerce:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes would allow leveraging the {{ lang }} handlebar params to dynamically switch the current language on the BigCommerce StoreFront.
It would work verry well with a new handlebar for retrieving a query parameter as shown bellow
`'use strict';
const utils = require('handlebars-utils');
const common = require('./lib/common.js');
const factory = globals => {
return function(url, key) {
url = common.unwrapIfSafeString(globals.handlebars, url);
if (utils.isString(url)) {
const decodedURL = unescape(url);
const query = decodedURL.split('?');
if (query.length > 1) {
const params = new URLSearchParams(query[1]);
return params.get(key);
} else return 'en';
}
};
};
module.exports = [{
name: 'getURLQueryParam',
factory: factory,
}];`