Do not return values from incrementVar and decrementVar helpers#160
Open
pvaladez wants to merge 1 commit intobigcommerce:masterfrom
Open
Do not return values from incrementVar and decrementVar helpers#160pvaladez wants to merge 1 commit intobigcommerce:masterfrom
pvaladez wants to merge 1 commit intobigcommerce:masterfrom
Conversation
…riable value aren't outputted to html
Contributor
|
@pvaladez I think some themes may rely on this kind of behaviour and this change might break backward compatibility. cc @bookernath @mattolson Any thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? Why?
The issue was first reported in issue #111.
The incrementVar and decrementVar helpers currently return the value of the handlebars variable, which results in the value being outputted to html.
How was it tested?
I removed the return lines on my local copy of stencil-cli/paper-handlebars, and afterward the helpers worked as expected and without printing the variable values to html.
I'm not very familiar with the paper-handlebars source, but I can see that other helper functions like assignVar do not return values.
Testing System Info
stencil-cli version: 3.6.4
node version: 12.21.0
OS: Windows 10
cc @bigcommerce/storefront-team @bookernath