Do not require mut on ParsedPath::element_mut #8891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicopap
added
C-Bug
mockersf
approved these changes
Jun 19, 2023
mockersf
added
the
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Jun 19, 2023
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Jun 19, 2023
# Objective `ParsedPath` does not need to be mut to access a field of a `Reflect`. Be that access mutable or not. Yet `element_mut` requires a mutable borrow on `self`. ## Solution - Make `element_mut` take a `&self` over a `&mut self`. bevyengine#8887 fixes this, but this is a major limitation in the API and I'd rather see it merged before 0.11. --- ## Changelog - `ParsedPath::element_mut` and `ParsedPath::reflect_element_mut` now accept a non-mutable `ParsedPath` (only the accessed `Reflect` needs to be mutable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
ParsedPathdoes not need to be mut to access a field of aReflect. Be that access mutable or not. Yetelement_mutrequires a mutable borrow onself.Solution
element_muttake a&selfover a&mut self.#8887 fixes this, but this is a major limitation in the API and I'd rather see it merged before 0.11.
Changelog
ParsedPath::element_mutandParsedPath::reflect_element_mutnow accept a non-mutableParsedPath(only the accessedReflectneeds to be mutable)