[Merged by Bors] - Reflect for Tonemapping and ClusterConfig
#6488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobhellermann
added
C-Feature
mockersf
approved these changes
Nov 5, 2022
tim-blackbird
approved these changes
Nov 5, 2022
james7132
added
the
S-Ready-For-Final-Review
james7132
approved these changes
Nov 6, 2022
IceSentry
approved these changes
Nov 6, 2022
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 7, 2022
# Objective - it would be useful to inspect these structs using reflection ## Solution - derive and register reflect - Note that `#[reflect(Component)]` requires `Default` (or `FromWorld`) until #6060, so I implemented `Default` for `Tonemapping` with `is_enabled: false`
Contributor
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
Reflect for Tonemapping and ClusterConfigReflect for Tonemapping and ClusterConfig
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - it would be useful to inspect these structs using reflection ## Solution - derive and register reflect - Note that `#[reflect(Component)]` requires `Default` (or `FromWorld`) until bevyengine#6060, so I implemented `Default` for `Tonemapping` with `is_enabled: false`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
#[reflect(Component)]requiresDefault(orFromWorld) until replaceFromWorldwithFromReflectinReflectComponent,ReflectResource#6060, so I implementedDefaultforTonemappingwithis_enabled: false