Skip to content

Inline register_type_data to cut down on binary size #22030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cart merged 2 commits into from
Dec 5, 2025
Merged

Inline register_type_data to cut down on binary size #22030

cart merged 2 commits into from
Dec 5, 2025

Conversation

@cart
Copy link
Member

@cart cart commented Dec 4, 2025 •
edited
Loading

Objective

My TypeData dependencies PR regressed native binary size by ~8mb.

(thank you twitcher)

image

Solution

@cart cart added this to the 0.18 milestone Dec 4, 2025
@cart cart added C-Performance A change motivated by improving speed, memory usage or compile times A-Reflection Runtime information about types labels Dec 4, 2025
IceSentry
IceSentry reviewed Dec 4, 2025
View reviewed changes
CorvusPrudens
CorvusPrudens approved these changes Dec 4, 2025
View reviewed changes
Copy link
Contributor

@CorvusPrudens CorvusPrudens left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm the same trend on macOS:

Pre-#22016: 91.59 MB
main: 94.27 MB
#22030: 91.60 MB

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 4, 2025
@cart cart added this pull request to the merge queue Dec 5, 2025
Merged via the queue into bevyengine:main with commit 6e88ae2 Dec 5, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mockersf mockersf mockersf approved these changes

+2 more reviewers

@IceSentry IceSentry IceSentry left review comments

@CorvusPrudens CorvusPrudens CorvusPrudens approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Reflection Runtime information about types C-Performance A change motivated by improving speed, memory usage or compile times S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

0.18

Development

Successfully merging this pull request may close these issues.

5 participants

@cart @IceSentry @mockersf @CorvusPrudens @alice-i-cecile