Delete unused WeightsCurve, and enable feature for bevy_animation. #21793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriyDev
added
C-Bug
Contributor
Author
|
I think this was accidentally broken in #20742. |
greeble-dev
approved these changes
Nov 10, 2025
Contributor
greeble-dev
left a comment
greeble-dev
left a comment
There was a problem hiding this comment.
LGTM. Although I think the real culprit was #15434 - that added the unused gltf_curves::WeightsCurve, and did a glob import of gltf_curves::*. Maybe this PR should avoid the glob just to be safe? Or I can make a follow up PR.
bevy/crates/bevy_gltf/src/loader/mod.rs
Lines 283 to 285 in 0c90f04
alice-i-cecile
approved these changes
Nov 10, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
atlv24
approved these changes
Nov 11, 2025
Contributor
atlv24
left a comment
atlv24
left a comment
There was a problem hiding this comment.
might want to make the bevy_internal gltf feature enable bevy_mesh too so the DefaultPlugins initializes it and bevy:: prelude includes it
mockersf
approved these changes
Nov 13, 2025
beicause
pushed a commit
to beicause/bevy
that referenced
this pull request
Nov 26, 2025
…evyengine#21793) # Objective - Fix `cargo b -p bevy_gltf --all-features` ## Solution - Delete an unused symbol with the same name. - Add the `bevy_mesh` feature on `bevy_animation` in `bevy_gltf`, so the correct WeightsCurve is chosen. ## Testing - CI, and running with `--all-features`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
cargo b -p bevy_gltf --all-featuresSolution
bevy_meshfeature onbevy_animationinbevy_gltf, so the correct WeightsCurve is chosen.Testing
--all-features.