Fix last keyframe #10842
Fix last keyframe #10842
Conversation
| Ok(i) => i, | ||
| Err(0) => continue, // this curve isn't started yet | ||
| Err(n) if n > curve.keyframe_timestamps.len() - 1 => continue, // this curve is finished | ||
| Err(n) if n > curve.keyframe_timestamps.len() - 1 => { |
There was a problem hiding this comment.
Since Err(n) is returned when no exact match was found this means that we sample after the last keyframe for n > len - 1. This curve should not contribute to the final pose by default in my opinion. The way most are familiar with this is probably an option "hold". I would continue here and special case it later when this option is implemented.
The rest looks fine
There was a problem hiding this comment.
I should add curves not contributing anymore is essentially only relevant when blending
There was a problem hiding this comment.
I gave it another thought and my suggestion doesnt result in the last keyframe being applied when we sample with t > curve duration. Im going to give it some more thought for something bullet-proof.
My current stance is that the last keyframe should be sampled when t(i - 1) < curve duration and t(i) > curve duration, but not when t(i - 1) > curve duration and t(i) > curve duration (unless we are holding the animation).
This means we need to keep track of when an animation was last sampled and whether it was sampled the last time the player ran.
Where t(i - 1) is the last time we sampled and t(i) is the time we currently sample.
alice-i-cecile
added
A-Animation
|
What are your plans with this PR? This is a useful fix: should I put it up for adoption? |
|
Yeah put it up for adoption |
alice-i-cecile
added
the
S-Adopt-Me
|
Closing as outdated/superseded by #15434 |
4 participants
Objective
Fixes: #10832
Solution
If the time is past the final keyframe, just set the transform using final transform
How to test:
Run the
animated_foxexample and bump the speed up a bunch withup arrow, then hit1to run the animation once. On main it won't always stop in the same position, with this PR it always stops on exact value of last keyframeWith main (slightly different results everytime):
With this PR:
Changelog
Fixed bug where animation wouldn't stop at the value of exactly the last keyframe