[Merged by Bors] - Entities and components section for ECS chapter #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
force-pushed
the
ecs-entities-components
branch
from
cef2b78 to
b88ee0d
Compare
alice-i-cecile
force-pushed
the
ecs-entities-components
branch
from
b88ee0d to
f0e85e6
Compare
doup
reviewed
May 10, 2022
Contributor
doup
left a comment
doup
left a comment
There was a problem hiding this comment.
I think, I saw a couple of typos on the example queries.
TheRawMeatball
approved these changes
May 10, 2022
Co-authored-by: Asier Illarramendi <asier@illarra.com>
Nilirad
approved these changes
May 11, 2022
Contributor
Nilirad
left a comment
Nilirad
left a comment
There was a problem hiding this comment.
This section is quite solid. I have a couple of perplexities about the terminology around entities but those are just personal ones.
|
|
||
| ## Working with components | ||
|
|
||
| Entities are entirely bare when they're spawned: they contain no data other than their unique [`Entity`] identifier. |
Contributor
There was a problem hiding this comment.
I really wish that Entity was actually called EntityId, so we don't have to always refer to it as “Entity identifier”.
Member
Author
There was a problem hiding this comment.
I agree, but not something I can do here.
Member
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 14, 2022
Ported from #182. # Status - [x] revisit and revise - [x] remove all use of direct world APIs - [x] distinguish between `Entity` type and entity concept
|
Build failed: |
alice-i-cecile
force-pushed
the
ecs-entities-components
branch
from
e89218a to
6b91ede
Compare
Member
Author
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
May 14, 2022
Ported from #182. # Status - [x] revisit and revise - [x] remove all use of direct world APIs - [x] distinguish between `Entity` type and entity concept
|
Pull request successfully merged into new-book. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from #182.
Status
Entitytype and entity concept