update testing versions to 8.19.11,9.2.5,9.3.0

[Dzuming]

Summary by CodeRabbit

• Chores

  • CI matrix updated to include Kibana 9.3.0 and 9.2.5; environment adjustments for master tests
  • Test dependencies updated (added network-idle helper)

• New Features

  • Tests and UI flows added/expanded for saving, opening, and restoring search sessions
  • New test helpers for element selection and toast handling; new page-object utilities

• Bug Fixes / Stability

  • Improved test synchronization using network-idle waits
  • Relaxed impersonation assertion to allow alternate issuer URLs
  • Cleanup now uses shared credentials for sample-data removal

• Config

  • Removed explicit prompt_for_basic_auth flag from test fixture configs

[coderabbitai]

📝 Walkthrough

Walkthrough

Updates CI workflow matrices; adds Kibana-version–gated logic and search-session flows in Discover tests; introduces Cypress helpers/page-objects (SearchSessions, KibanaToast), a network-idle helper, and new/adjusted support commands and typings; removes prompt_for_basic_auth from fixtures; bumps a few test deps.

Changes

Cohort / File(s)	Summary
CI/CD Workflow Updates .github/workflows/trigger-e2e-tests.yml	Updated job matrices to include newer stack versions (9.3.0, 9.2.5, 8.19.11) and adjusted environment lists (e.g., shortened master-e2e-tests envs).
Discover spec & search-sessions e2e-tests/cypress/e2e/Discover.cy.ts	Added semver-based gating, switched to Login.initialization, integrated EsApiAdvancedClient for index management, added search-session save/open test for older Kibana versions, and cleanup of search-sessions index.
Small spec edits e2e-tests/cypress/e2e/Impersonate.cy.ts, e2e-tests/cypress/e2e/Index-management.cy.ts, e2e-tests/cypress/e2e/Reporting.cy.ts, e2e-tests/cypress/e2e/Observability.cy.ts	Relaxed issuer assertion; tiny formatting change; reporting cleanup uses shared userCredentials; observability assertions use existence + scrollIntoView.
Fixtures: ReadonlyREST flags removed e2e-tests/cypress/fixtures/reportingSettings.yaml, .../roSettings.yaml, .../roStrictSettings.yaml, .../testSettings.yaml	Removed prompt_for_basic_auth: false entries from multiple ReadonlyREST fixture files.
Support commands & API typings e2e-tests/cypress/support/commands.ts, e2e-tests/cypress/support/e2e.ts	Added findByDataTestSubj command; widened getByDataTestSubj typings; removed failOnStatusCode from esGet/esDelete signatures; added cypress-network-idle import.
New page objects e2e-tests/cypress/support/page-objects/SearchSessions.ts, .../KibanaToast.ts	Added SearchSessions (count/open helpers) and KibanaToast.closeToastMessage.
Discover page-object additions e2e-tests/cypress/support/page-objects/Discover.ts	Added openSaveSessionPanel, pressSaveSessionButton, pressManageSessionsButton, verifyDiscoverFromSearchSessionCorrectlyRestored (version-aware).
Page-object and sync tweaks e2e-tests/cypress/support/page-objects/IndexManagement.ts, .../Reporting.ts, .../RoAndRoStrictKibanaAccessAssertions.ts	IndexManagement: forced click on confirm delete; Reporting: conditional toast close for Kibana ≥9.3.0; RoAndRoStrictKibanaAccessAssertions: replaced specific intercept/wait with cy.waitForNetworkIdle('*.pbf', ...).
Dependency updates e2e-tests/package.json	Added cypress-network-idle; bumped patch versions for form-data and js-yaml.

Sequence Diagram(s)

sequenceDiagram
  participant Test as Cypress Test
  participant PO as Discover PageObject
  participant Kibana as Kibana UI
  participant ES as Elasticsearch (EsApiAdvancedClient)

  Test->>PO: Login.initialization(credentials)
  Test->>PO: open Discover and run query
  alt Kibana < 9.0.0
    PO->>Kibana: wait for DiscoverSearchCompleted
  end
  Test->>ES: create indexWithSearchSessions
  Test->>PO: openSaveSessionPanel() -> pressSaveSessionButton()
  PO->>Kibana: trigger save session (writes search-sessions index)
  Test->>PO: pressManageSessionsButton()
  PO->>Kibana: open saved session
  PO->>Test: verifyDiscoverFromSearchSessionCorrectlyRestored()
  Test->>ES: delete search-sessions index (cleanup)

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• synchronize tests with readonlyrest kbn repo #66 — Overlapping edits to Discover tests, SearchSessions, Cypress support APIs, and CI workflow matrices.
• update matrix and adjust tests #57 — Concurrent changes touching page-objects, support commands/typings, and workflow version matrix updates.
• [RORDEV-1411] 9.0.0 beta1 support #40 — Introduces semver-based gating and version-dependent test logic in related e2e tests.

Suggested reviewers

• coutoPL

Poem

🐰 I hopped through matrices, bumped each version bright,
I nudged the sessions, tuned the test-sweet light,
Network idle listens, toasts now close with care,
New helpers scurry, tidy steps everywhere —
A carrot for CI, and tests that sleep at night 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: updating testing versions to specific version numbers (8.19.11, 9.2.5, 9.3.0) across workflow matrices and test files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch update-matrix-to-8.19.11,9.2.5,9.3.0

---

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments

e2e-tests/cypress/support/page-objects/Impersonate.ts (1)

187-192: Invert the condition to eliminate the empty if block.

An empty if body with all logic in the else branch hurts readability. Negate the condition instead.

♻️ Suggested refactor

-    if (semver.gte(getKibanaVersion(), '9.3.0')) {
-
-    } else {
+    if (semver.lt(getKibanaVersion(), '9.3.0')) {
       Loader.loading();
-
     }

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}