fix some errors to be compilabe and well executable. …#1
Open
tigrazone wants to merge 1 commit intoberkus:workfrom
Open
fix some errors to be compilabe and well executable. …#1tigrazone wants to merge 1 commit intoberkus:workfrom
tigrazone wants to merge 1 commit intoberkus:workfrom
Conversation
…_PI, fix targa saver. make image size 4x bigger
berkus
requested changes
Nov 11, 2021
Owner
berkus
left a comment
berkus
left a comment
There was a problem hiding this comment.
hi!
can you please split the commits logically (one change per commit)?
| { | ||
| double x,y; // sample point | ||
| Ray ray; // pixel ray | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix absense of M_PI, fix targa saver. make image size 4x bigger