Fix lookup for columns that are multiples of 26#2
Open
sparkalyn wants to merge 1 commit intobennadel:masterfrom
Open
Fix lookup for columns that are multiples of 26#2sparkalyn wants to merge 1 commit intobennadel:masterfrom
sparkalyn wants to merge 1 commit intobennadel:masterfrom
Conversation
Fixes "The element at position 0 cannot be found. " for spreadsheets that assign aliases to columns ?Z columns (AZ, BZ, etc.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where spreadsheets that use aliases on columns greater than 51 get an error: "The element at position 0 cannot be found. "
This happens because the code to determine the 2nd character of the column reference (AA, AB, etc.) uses the mod operator. If the celI index is a multiple of 26, modulus returns 0 resulting in an error referencing the ColumnLookup array.
This change adds an IIF statement to return the length of the array (26) instead of the result of the modulus if that result is 0.