Open
Conversation
The logging is almost useless for users but a developer can debug in IDE. The raw keys bytes are not saying anything. We have errors to return a message to a caller. In the same time the code needs to be compiled and it makes the program slower because it resides in CPU cache.
Remove deprecated isDebugMode
These fields are never read but consumes memory. If we are going to create many instances of the Pricer then it will consume a lot of memory and make program slower
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logging is almost useless for users but a developer can debug in IDE.
The raw keys bytes are not saying anything.
We have errors to return a message to a caller.
In the same time the code needs to be compiled and it makes the program slower because it resides in CPU cache.
I going to send another PR with a performance improvement and for it I anyway need to broke the logging in some places.
I benchmarked and even when the logging is disabled it still makes code slower because it takes some place in CPU instructions cache.
The PR has some minor refactoring of tests.