Skip to content

Conversation

@urbanskimichal
Copy link
Contributor

Work done:

  • Added error message when unrecognised frame occurs during compilation.
  • Added translatable message about the change in editor.
  • Updated editor to show Changes in 4.0 document.

For now I don't think I'm ready for the auto-fix, but can think about it in the future.
This is my first contribution so I'm waiting for suggestions or opinions.

final String undefinedName = args[0];
if (undefinedName.equals("frame")) {
result = Language.interpolate("editor.status.item_removed", undefinedName, "surface");
}
Copy link
Collaborator

@sampottinger sampottinger Jun 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor request... I think we have been doing } else {

}
}

static public void showChangesV4() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this @urbanskimichal! What are your thoughts on replacing showChanges outright?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually how about doing a showChangesV3 and showChangesV4 (same for handleCrustyCode). See urbanskimichal#2.

@sampottinger
Copy link
Collaborator

I made the above changes ahead of an integration branch build. It's ok if we go a different direction. See urbanskimichal#2. Thank you again @urbanskimichal!

@sampottinger
Copy link
Collaborator

This is available on an integration branch at https://github.com/sampottinger/processing4 (master) for testing in the context of other open PRs with a community build at https://www.datadrivenempathy.com/processing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants