Passes pageSize to initial setData call#174
Open
mr-winter wants to merge 1 commit intobencripps:masterfrom
Open
Passes pageSize to initial setData call#174mr-winter wants to merge 1 commit intobencripps:masterfrom
mr-winter wants to merge 1 commit intobencripps:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
==========================================
+ Coverage 75.78% 76.01% +0.22%
==========================================
Files 111 112 +1
Lines 5097 5144 +47
Branches 366 366
==========================================
+ Hits 3863 3910 +47
- Misses 957 958 +1
+ Partials 277 276 -1
Continue to review full report at Codecov.
|
Owner
|
I know the current test suite is passing, but are there any new tests we should add to check how this new code affects the current implementation or the newly introduced behavior? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds pageSize to extraParameters for initial remote setData call.
Also gitignores intellij idea folder.