Skip to content

Changes to allow running on localhost monolith #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dshin0510 wants to merge 1 commit into from
Closed

Changes to allow running on localhost monolith #31

dshin0510 wants to merge 1 commit into from

Conversation

@dshin0510
Copy link

@dshin0510 dshin0510 commented Dec 4, 2025 •
edited
Loading

This PR has all the fixes that are necessary to work with localhost monolith and ngrok

  • README changes to reflect sunsetting old cloudflare references
  • Docker changes to allow friendly network between local monolith and tunnel (ie network_mode: host for benchling-app and tunnel services)
  • Override SDK client with SSL client auth off for local monolith: see thread

@dshin0510 dshin0510 changed the title Changes to allow running Changes to allow running on localhost monolith Dec 4, 2025
@dshin0510 dshin0510 force-pushed the dannyshin-localmonolith-and-grok branch from f34ed3e to 65744dd Compare December 4, 2025 18:46
@dshin0510 dshin0510 marked this pull request as ready for review December 4, 2025 18:49
@dshin0510 dshin0510 closed this Dec 4, 2025
@dshin0510
Copy link
Author

dshin0510 commented Dec 4, 2025

Closed and replaced by:
https://github.com/benchling/benchling-apps-internal-onboarding/pull/14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damola-benchling damola-benchling Awaiting requested review from damola-benchling

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dshin0510