Add automatic mixed precision training for ATME#2
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| self.use_amp = bool(getattr(opt, 'use_amp', False)) and self.isTrain and torch.cuda.is_available() | ||
| self.scaler = GradScaler(enabled=self.use_amp) |
There was a problem hiding this comment.
[P1] Enable AMP only when model runs on CUDA device
self.use_amp is set to True whenever torch.cuda.is_available() is true, regardless of whether the model is actually placed on CUDA. When the user selects CPU execution (e.g. --gpu_ids -1) on a machine that still has CUDA available, optimize_parameters enters a CUDA autocast context and uses GradScaler while all tensors stay on CPU. torch.cuda.amp raises at runtime in that configuration, so CPU training now crashes unless AMP is manually disabled. The previous implementation worked on CPU; this change regresses that path. The flag should also check the selected device (e.g. non-empty self.gpu_ids or self.device.type == 'cuda') before enabling AMP.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68d35ae1eeec83319cf61e547d8fb9ae