Update server to work with asyncio v3 #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There wew a couple of breaking API changes in the asyncio v3 upgrade. these changes broke (among others) the `max_concurrency` support and the `app.shutdown()` clean shutdown (`cancel()` should be called on `Task`s). This also drops the asyncio v2/v3 conditional logic and instead just prints a warning if the system is running an unexpected asyncio version.
Author
|
I think this should also fix #56 |
Author
|
I just noticed this other fix: #52 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of breaking API changes in the asyncio v3 upgrade. these changes broke (among others) the
max_concurrencysupport and theapp.shutdown()clean shutdown (cancel()should be called onTasks).This also drops the asyncio v2/v3 conditional logic and instead just prints a warning if the system is running an unexpected asyncio version.