Skip to content

Conversation

@0x313
Copy link

@0x313 0x313 commented Mar 22, 2025

This greatly improves booting speed, especially when running a system with many strata

@paradigm
Copy link
Member

Apologies for the delayed response.

/bedrock/libexec/brl-enable locks almost to entire program lifetime, forcing serialization, and so my expectation is this has a negligible performance difference. If it does have a performance difference, then that might indicate the locking is broken. That said, I could be missing something.

Have you done any benchmarking and seen actual improvement, or is it just your expectation that this improves things in theory?

I'm concerned there's a subtle, potentially dangerous bug here. I realize this is an already delayed response, but I'm going to hold off on making changes until I can test this thoroughly.

Most of the performance overhead is from excessive binary context switching. For the future 0.8.x I plan to have this entire subsystem rewritten in a compiled language, with much more fine-grained use of locking. I'm expecting this to be unnoticeable on even on low-end hardware at that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants