Introduce ApiComponent as proxy for BEditaClient#21
Draft
batopa wants to merge 1 commit intobedita:masterfrom
Draft
Introduce ApiComponent as proxy for BEditaClient#21batopa wants to merge 1 commit intobedita:masterfrom
batopa wants to merge 1 commit intobedita:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
============================================
+ Coverage 85.53% 86.45% +0.91%
- Complexity 132 141 +9
============================================
Files 16 17 +1
Lines 325 347 +22
============================================
+ Hits 278 300 +22
Misses 47 47
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a proposal to try to make more easy to handle errors thrown by
BEditaClient.The Component is a proxy to
BEditaClientand should be setup inController::initialize()methodIn this way the component throws exceptions as
BEditaClientusually do.In the
Controlleraction we can use the component transparently as if we were using aBEditaClientinstanceIf we don't want to throw exception but handle the error we can do
When the exceptions are disabled the last error is stored in
ApiComponentand reset at every request delegated toBEditaClient