Skip to content

[common]: Add PodDisruptionBudget (PDB) support #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
NicolasHaas wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[common]: Add PodDisruptionBudget (PDB) support #169

NicolasHaas wants to merge 1 commit into from

Conversation

@NicolasHaas
Copy link

@NicolasHaas NicolasHaas commented Dec 9, 2025

Description

This PR adds Pod Disruption Budget (PDB) support to the common chart.

Changes

  • Added _pdb.yaml template for PDB resources
  • Added pdb: false to includes section in values.yaml
  • Added pdbs configuration in components section
  • Updated includes.yaml to include PDB template
  • Updated README.md.gotmpl with PDB documentation
  • Added PDB tests to CI values file
  • Bumped chart version to 12.7.0

Features

  • Support for minAvailable or maxUnavailable (mutually exclusive)
  • Support for unhealthyPodEvictionPolicy (Kubernetes 1.26+)
  • Support for overrideSelectors for custom label selectors
  • Follows the same pattern as services, networkpolicies, etc.

Usage Example

includes:
  pdb: true

components:
  my-app:
    pdbs:
      main:
        deploy: true
        minAvailable: 1

@NicolasHaas NicolasHaas requested review from a team as code owners December 9, 2025 14:14
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 9, 2025
@NicolasHaas
[common]: add PodDisruptionBudget (PDB) support for components
75aa57b 
Signed-off-by: Nicolas Haas <116176330+NicolasHaas@users.noreply.github.com>
@NicolasHaas NicolasHaas force-pushed the feat/common-pdb-support branch from 44b90d8 to 75aa57b Compare December 9, 2025 14:19
@NicolasHaas NicolasHaas marked this pull request as draft December 9, 2025 14:23
wthhub
wthhub approved these changes Dec 11, 2025
View reviewed changes
Copy link
Contributor

@wthhub wthhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for your contribution. May you also update the values.schema.json?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wthhub wthhub wthhub approved these changes

Assignees

No one assigned

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NicolasHaas @wthhub