Merged
Conversation
Member
|
Woohoo! Thanks so much for this awesome PR, wise bearded bear bro. Because you are both wise and bearded, you are indeed right about everything – especially:
...indeed. Totally makes sense. Not all interactive shells are terminals. Pyodide: you are the case in point. Let's merge this ASAP. Tests are spuriously failing, which is another issue altogether. Oh, and...
ohnoes. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this elegant little package!
This updates the signature of the
ipythonargument to be the superclassInteractiveShell, which makes things work better inside alternate runtimes than anipythonCLI, such asipykernel, or the even more exotic pydodide-kernel.These work today... unless one has already added
beartypeThe Hard Way:Also, of note: would love to ship this for
conda-forge, but would ideally be able to use one of the following for building from source:.tar.gzon PyPI (preferred by most downstreams)Thanks again 🐻❄️ !