Conversation
- Require PHP 8.2+, update dependencies (PHPUnit 10, Symfony Cache 7) - Convert Doctrine annotations to PHP 8 attributes (#[Ssr], #[SsrCacheConfig]) - Use constructor property promotion with readonly - Add return types and PHPDoc generics throughout - Update V8Js binding for new constructor signature (3 params) - Migrate Symfony Cache from Simple\* to Psr16Cache adapter - Replace .php_cs/phpmd.xml with .php-cs-fixer.dist.php/phpstan.neon - Update PHPUnit config and tests to PHPUnit 10 format - Remove Doctrine AnnotationRegistry from bootstrap
Remove hardcoded test path and require bundleSrcBasePath in constructor, matching SsrModule's interface.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Add ci.yml with PHPUnit, static analysis, coding standards, and V8Js Docker jobs
- Add #[Group('v8js')] attribute to tests requiring V8Js extension
- Update CLAUDE.md with V8Js optional info and test commands
Member
Author
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
- Add src/tests directories to phpcs.xml for default scanning
- Remove #[Group('v8js')] from ApcCacheSsrModuleTest since it doesn't
require V8Js and should run in normal PHPUnit job where APCu is available
- Restore #[Group('v8js')] on ApcCacheSsrModuleTest (requires V8Js binding)
- Add $PHPIZE_DEPS to Docker job for proper APCu compilation
- Add verification step to confirm APCu is loaded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Breaking Changes
ApcSsrModulenow requires$bundleSrcBasePathconstructor parameterTest plan
composer testpasses (7/7 tests)phpstan analysepassesphpcspasses