Skip to content

Update code.php#426

Open
oceanwap wants to merge 1 commit intobddicken:mainfrom
oceanwap:patch-1
Open

Update code.php#426
oceanwap wants to merge 1 commit intobddicken:mainfrom
oceanwap:patch-1

Conversation

@oceanwap
Copy link

@oceanwap oceanwap commented Apr 10, 2025

I have:

  • Read the project README, including the benchmark descriptions
  • Read the PR template instructions before I deleted them
  • Understood that if I have changed something that could impact performance of one or more contributions, I should provide results benchmark runs, using the run.sh script, from before and after the change.

Description of changes

PHP JIT doesn't work so well for global code, wrapping it in a function makes JIT work better and code faster.
Also in a real word project a code would be wrapped in a class or function, so it's more realistic scenario.

@oceanwap
Copy link
Author

@bddicken Please review the PR

@jszczypk
Copy link

jszczypk commented Dec 3, 2025

I have got almost 40% shorter time with JIT by wrapping the code in function.

@oceanwap
Copy link
Author

@bddicken
I am not sure who will merge it, can someone mere it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants