Optimize Levenshtein Distance Computation (Remove Duplicates)#315
Open
devalexandre wants to merge 3 commits intobddicken:mainfrom
Open
Optimize Levenshtein Distance Computation (Remove Duplicates)#315devalexandre wants to merge 3 commits intobddicken:mainfrom
devalexandre wants to merge 3 commits intobddicken:mainfrom
Conversation
Collaborator
|
Hi, thanks for contributing! 🙏 I'm not sure what
Means, but it sounds like it dodges the work that all languages are required to do. The changes to the fibonacci and levenshtein code are definitively non-compliant. The fibonacci is by intention naïve, and for levenshtein we so far require the redundant checks. Also, we do want benchmark |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have:
Description of changes
Fixes #314
This pull request provides optimizations for three benchmarks:
Loops
Fibonacci
Levenshtein
Rationale
Benchmarks
Additional Notes
Thank you for reviewing this PR! If there are any questions or feedback, please let me know.