gas and nonce manager feature #160
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-manager merging latest develop branch changes into this branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gas Manager Feature Description:
Gas manager implementation is very straightforward where the gas prices such as priority fee, gas price, fee history are fetched in background and stored in a cache for every 30 seconds. The node can consume this directly from memory cache which avoid the RPC call and we save latency here.
Nonce Manager Feature Description:
Nonce manager is a bit complicated one which might looks so simple in terms of code but complicated under the hood.
I've covered a detailed edge case report here and would suggest the reviewer to take a look and skim through it while reviewing
mee-node/src/modules/nonce-manager/nonce-manager.service.ts
Line 7 in 908130e