Conversation
|
@copilot fix linting errors |
|
@FerriolCalvet I've opened a new pull request, #300, to work on those changes. Once the pull request is ready, I'll request review from you. |
provide links that clearly state licensing
cleanup and organize
git action checks
git action checks
git action checks
spelling Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
clarify and cleanup
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## Licensing (Docker Engine vs Docker Desktop) | ||
|
|
||
| The *Docker Engine* (the runtime/daemon `dockerd` and related components) is open source and distributed under the | ||
| **Apache License 2.0** (a permissive license). Docker explicitly documents this in the Docker Engine manual: | ||
|
|
||
| * Docker Engine licensing: | ||
| [https://docs.docker.com/engine/#licensing](https://docs.docker.com/engine/#licensing) | ||
| * Docker Engine upstream license (Moby project): | ||
| [https://github.com/moby/moby/blob/master/LICENSE](https://github.com/moby/moby/blob/master/LICENSE) | ||
|
|
||
| Note: Docker Desktop is a separate product with its own subscription/license terms; the Docker Desktop is licensed under | ||
| the | ||
| [Docker Subscription Service Agreement overview](https://www.docker.com/legal/docker-subscription-service-agreement/). |
There was a problem hiding this comment.
PR description says a note was added clarifying Docker’s free use for educational/personal/research/non-commercial purposes, but that policy statement does not appear in this document. Please add the described usage-policy note here (or adjust the PR description to match what was actually changed).
sofiathelima
left a comment
sofiathelima
left a comment
There was a problem hiding this comment.
Committed some changes to clarify what is actually stated in the Docker webpages regarding licensing.
Added some minor suggestions.
Also could add installation instructions/setup section (or make an issue to do so).
Approved ✨
|
|
||
| ## Create Docker containers | ||
|
|
||
| Internally we have this GitHub repository with the receipes for many of the custom containers that we are generating and |
There was a problem hiding this comment.
Typo: "receipes" should be "recipes".
| Internally we have this GitHub repository with the receipes for many of the custom containers that we are generating and | |
| Internally we have this GitHub repository with the recipes for many of the custom containers that we are generating and |
| ## Create Docker containers | ||
|
|
||
| Internally we have this GitHub repository with the receipes for many of the custom containers that we are generating and | ||
| hosting in our dockerhub. |
There was a problem hiding this comment.
Minor capitalization
| hosting in our dockerhub. | |
| hosting in our Docker Hub |
This pull request updates the
docs/Tools/Docker.mddocumentation to clarify Docker's usage policy, provide guidelines for creating custom containers, and reference internal resources. The main focus is on helping users understand licensing, usage restrictions, and the workflow for contributing containers.Docker usage and contribution guidelines:
References and documentation: