Conversation
Needs some discussion with @mzeren-vmw about whether this is the shape we want to commit to, vs. having a `package_info` rule as well.
|
See also: bazelbuild/bazel#22403, which asks for a way of attaching license info to a specific target (which we will need for |
| load("@rules_license//rules:license.bzl", "license") | ||
|
|
||
| package( | ||
| default_package_metadata = [":license"], |
There was a problem hiding this comment.
If people are doing the integration, we should take the same opportunity to add package_info rules to pull package names and versions into the BUILD file in a uniform way.
aiuto
left a comment
There was a problem hiding this comment.
This looks mostly reasonable to me.
My only question is the name of the .md file. ADD_PKG_MGR could be interpreted as "how to add a package manager" rather than the intent, which is the (too) long winded "How to integrate rules_license into package managers.
Does |
|
We can declare multiple |
|
Having now implemented this for
|
|
Ping @tonyaiuto this is the thing preventing me from volunteering to update many of the language rulesets |
Allows package manager implementations like rules_jvm_external to begin declaring the licenses or other metadata about third-party packages they fetch and add to the dependency graph.
Needs some discussion with @mzeren-vmw about whether this is the shape we want to commit to, vs. having a
package_inforule as well.