Use a private namespace for the java dependencies#676
Open
shs96c wants to merge 1 commit intobazelbuild:masterfrom
Open
Use a private namespace for the java dependencies#676shs96c wants to merge 1 commit intobazelbuild:masterfrom
shs96c wants to merge 1 commit intobazelbuild:masterfrom
Conversation
The guidelines for rulesets that are not expected to be root modules (such as this one) is that they only contribute to the default `maven` workspace if their dependencies are required by at runtime by production code that uses the ruleset. Switching to using a private workspace ensures that this ruleset plays nicely in larger projects. Also added a lock file to avoid the need to re-run the maven dependency resolution each time the bazel daemon starts.
Collaborator
|
@shs96c Have you seen the question/concern in bazel-contrib/rules_jvm_external#916 (comment) In particular, here we have dependencies like between j2cl and rules_closure. If all j2cl tool dependencies (rules_closure, protobuf, google_common etc) use different maven namespaces how do we deal with with many versions of libs that we end up receiving on the tool side? The problem in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guidelines for rulesets that are not expected to be root modules (such as this one) is that they only contribute to the default
mavenworkspace if their dependencies are required by at runtime by production code that uses the ruleset.Switching to using a private workspace ensures that this ruleset plays nicely in larger projects.
Also added a lock file to avoid the need to re-run the maven dependency resolution each time the bazel daemon starts.