Add js output to list of files when being used as a filegroup#252
Open
blakesmith wants to merge 1 commit intobazelbuild:masterfrom
Open
Add js output to list of files when being used as a filegroup#252blakesmith wants to merge 1 commit intobazelbuild:masterfrom
blakesmith wants to merge 1 commit intobazelbuild:masterfrom
Conversation
Member
|
Can one of the admins verify this patch? |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Author
|
Just signed the CLA. |
|
CLAs look good, thanks! |
Collaborator
|
There hasn't been any activity in this PR for very long time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been using the
closure_css_binaryrule in tandem with theresourcesattribute of ajava_libraryrule. Thename.cssandname.css.mapwere being built into the jar correctly, but thename.css.jsfile was missing:Since I'd like to load the mappings into a Java backend for making a
SoyCssRenamingMap, I need this file to parse and render server side templates. This PR adds it to the file output: