Allow overriding os_family in rbe_autoconfig#935
Allow overriding os_family in rbe_autoconfig#935kevingessner wants to merge 1 commit intobazelbuild:masterfrom
Conversation
Provides a workaround for bazelbuild#895. Use like this: rbe_autoconfig( name = "engflow_remote_config", os_family = "Linux", java_home = "/usr/lib/jvm/11.29.3-ca-jdk11.0.2/reduced", use_checked_in_confs = "Force", )
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@kevingessner FYI we're exploring the possibility of exploring rbe_autoconfig for config generation with a standalone Go CLI (see PR #936 for a proof of concept). We expect this CLI will make it easier to generate configs (mostly for our internal config generation automation as well as for new users setting up config generation for themselves). The CLI currently supports Linux & Windows to start out but I imagine Mac OS support should be trivial to add. We're still experimenting with this tool and will share more details in the coming weeks but initial thoughts are welcome. Right now the Go code also potentially be used as a library and we would be open to suggestions on what components of the tool should be exported to make it more pluggable. This will be especially important for potential Windows/OSX specific support that we might not initially be able to set up testing for. |
(Rebased and making a PR on behalf of @ulfjack, who wrote this patch)
Provides a workaround for #895.
Use like this:
rbe_autoconfig(
name = "engflow_remote_config",
os_family = "Linux",
java_home = "/usr/lib/jvm/11.29.3-ca-jdk11.0.2/reduced",
use_checked_in_confs = "Force",
)