Skip to content

Enable no_warn_duplicate_libraries for Xcode 15+ #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
keith wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Draft

Enable no_warn_duplicate_libraries for Xcode 15+ #430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion crosstool/cc_toolchain_config.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2566,9 +2566,14 @@ please file an issue at https://github.com/bazelbuild/apple_support/issues/new
# As of Xcode 15, linker warnings are emitted if duplicate `-l` options are
# present. Until such linkopts can be deduped by bazel itself, we disable
# these warnings.
is_15_or_above = False
if xcode_config.xcode_version():
is_15_or_above = xcode_config.xcode_version() >= apple_common.dotted_version("15.0")
no_warn_duplicate_libraries_feature = feature(
name = "no_warn_duplicate_libraries",
enabled = "no_warn_duplicate_libraries" in ctx.features,
enabled = "no_warn_duplicate_libraries" in ctx.features or
(is_15_or_above and
"no_warn_duplicate_libraries" not in ctx.disabled_features),
flag_sets = [
flag_set(
actions = _DYNAMIC_LINK_ACTIONS,
Expand Down