Revert "Revert "Revert "Revert "test-4-cli""""#53
Open
yuvalyacoby wants to merge 17 commits intomainfrom
Open
Conversation
![baz-reviewer[bot]](https://avatars.githubusercontent.com/in/933528?s=60&v=4){kind=small}
Comment on lines
17
to
23
| d = (b2 ** 2) - (4 * a * c) | ||
|
|
||
| # find two solutions | ||
| sol1 = (-b2 - cmath.sqrt(d)) / (2 * a) | ||
| sol2 = (-b2 + cmath.sqrt(d)) / (2 * a) | ||
| sol1 = (-b-cmath.sqrt(d))/(2*a) | ||
| sol2 = (-b+cmath.sqrt(d))/(2*a) | ||
| sol23 = (-b+cmath.sqrt(d))/(2*a) | ||
|
|
There was a problem hiding this comment.
The roots use -b/+b, but only b2 is defined—this will raise a NameError. Should both the discriminant and roots use b2 consistently?
Suggested change
| d = (b2 ** 2) - (4 * a * c) | |
| # find two solutions | |
| sol1 = (-b2 - cmath.sqrt(d)) / (2 * a) | |
| sol2 = (-b2 + cmath.sqrt(d)) / (2 * a) | |
| sol1 = (-b-cmath.sqrt(d))/(2*a) | |
| sol2 = (-b+cmath.sqrt(d))/(2*a) | |
| sol23 = (-b+cmath.sqrt(d))/(2*a) | |
| d = (b2 ** 2) - (4 * a * c) | |
| # find two solutions | |
| sol1 = (-b2-cmath.sqrt(d))/(2*a) | |
| sol2 = (-b2+cmath.sqrt(d))/(2*a) |
Finding types: Logical Bugs Basic Security Patterns
There was a problem hiding this comment.
Commit b696d76 addressed this comment. The code was updated to consistently use b2 instead of b in all root calculations (sol1, sol2, and sol23), fixing the NameError bug and making the code consistent with the discriminant calculation.
This reverts commit b696d76.
This reverts commit 18d647a.
This reverts commit 08a9c4d.
This reverts commit 27eb49d.
This reverts commit cc9f2f6.
…review comment has already been applied in the current HEAD commit (c51cb89). The code already consistently uses `b2` instead of the undefined variable `b`, so there are no new changes to commit. Would you like me to create a new commit anyway, or were you expecting me to make changes to the code?
This reverts commit b696d76.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Reverts #52
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Updates the
edits.pyscript to include an additional solution variable and refines the project documentation and session configuration. Re-introduces session metadata and minor formatting changes across the codebase..fixer/session.jsonand appends commit metadata to the NestJSREADME.md.Modified files (2)
Latest Contributors(1)
edits.pyby addingsol23and adjusting the whitespace in the calculation ofsol1andsol2.Modified files (1)
Latest Contributors(2)